Subtype IntSet and SparseIntSet to AbstractSet{Int} - #983
Open
JohnCobbler wants to merge 1 commit into
Open
Conversation
Enable AbstractSet algorithms while keeping concrete container types. Add emptymutable/copymutable/filter! (and SparseIntSet delete!) so filter, setdiff, and Base's intersect!(::AbstractSet, ::AbstractSet) stay correct. Resolve symdiff!/intersect! AbstractSet dispatch. Fixes JuliaCollections#908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither
IntSetnorSparseIntSetsubtypedAbstractSet, so generic setalgorithms and APIs that dispatch on
AbstractSetignored them.Make both
<: AbstractSet{Int}and add the helpers Base's set fallbacks need:emptymutable/copymutablesofilterandsetdiffreturn the sameconcrete type instead of falling back to
Setfilter!viaunsafe_filter!(BitSet pattern) sointersect!(s::AbstractSet, s2::AbstractSet)worksdelete!forSparseIntSet(was onlypop!) for the filter! pathsymdiff!(::IntSet, ::AbstractSet)andintersect!(::SparseIntSet, ::AbstractSet)for unambiguous dispatch
Same-type
==/</<=methods remain more specific (unchanged). Cross-typeequality with
Set/ between the two types becomes available via AbstractSetfallbacks.
Docs note the
AbstractSet{Int}relationship.Fixes #908